[PATCH] D101130: [PowerPC] Provide XL-compatible builtins in altivec.h

Jinsong Ji via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 23 08:01:19 PDT 2021


jsji added inline comments.


================
Comment at: clang/lib/Headers/altivec.h:3065
+                                                   (__b)),                     \
+             vector unsigned long long                                         \
+           : (__builtin_vsx_xvcvuxdsp((vector unsigned long long)(__a)) *      \
----------------
jsji wrote:
> Can we also add comments about what is the major difference with and without `__XL_COMPAT_ALTIVEC__` , for long term maintenance?
> Can we also add comments about what is the major difference with and without `__XL_COMPAT_ALTIVEC__` , for long term maintenance?

I know they are in commit message, but I think comments in source code would be more helpful than in commit message. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101130/new/

https://reviews.llvm.org/D101130



More information about the cfe-commits mailing list