[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

[Dávid Bolvanský via Phabricator via cfe-commits]

xbolva00 added a comment.

In D79714#2711871 <https://reviews.llvm.org/D79714#2711871>, @uabelho wrote:

> Hi,
>
> With this commit I get failures in the following testcases when building check-runtimes on trunk:
>
>   Failed Tests (29):
>     libc++ :: libcxx/debug/containers/db_sequence_container_iterators.pass.cpp
>     libc++ :: libcxx/gdb/gdb_pretty_printer_test.sh.cpp
>     libc++ :: std/containers/sequences/vector.bool/assign_copy.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/assign_move.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/copy.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/copy_alloc.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/emplace.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/erase_iter.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/erase_iter_iter.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/insert_iter_initializer_list.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/insert_iter_iter_iter.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/insert_iter_size_value.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/insert_iter_value.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/iterators.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/move.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/move_alloc.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/resize_size.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/resize_size_value.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/shrink_to_fit.pass.cpp
>     libc++ :: std/containers/sequences/vector.bool/size.pass.cpp
>     libc++ :: std/containers/sequences/vector/vector.cons/deduct.pass.cpp
>     libc++ :: std/utilities/template.bitset/bitset.members/left_shift.pass.cpp
>     libc++ :: std/utilities/template.bitset/bitset.members/op_eq_eq.pass.cpp
>     libc++ :: std/utilities/template.bitset/bitset.members/right_shift.pass.cpp
>     libc++ :: std/utilities/template.bitset/bitset.members/to_ullong.pass.cpp
>     libc++ :: std/utilities/template.bitset/bitset.members/to_ulong.pass.cpp
>     libc++ :: std/utilities/template.bitset/bitset.operators/op_and.pass.cpp
>     libc++ :: std/utilities/template.bitset/bitset.operators/op_not.pass.cpp
>     libc++ :: std/utilities/template.bitset/bitset.operators/op_or.pass.cpp
>
> They all get -Wdeprecated-copy warnigns and then with -Werror they fail.
> Is this something you've seen or considered?

Can you try this fix?

  diff --git a/libcxx/utils/libcxx/test/params.py b/libcxx/utils/libcxx/test/params.py
  index ddf277dea246..abf712e78a61 100644
  --- a/libcxx/utils/libcxx/test/params.py
  +++ b/libcxx/utils/libcxx/test/params.py
  @@ -12,6 +12,7 @@ from libcxx.test.features import _isMSVC
   _warningFlags = [
     '-Werror',
     '-Wall',
  +  '-Wno-deprecated-copy',
     '-Wextra',
     '-Wshadow',
     '-Wundef',


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79714/new/

https://reviews.llvm.org/D79714