[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

Yuanfang Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 22 23:53:21 PDT 2021


ychen added a comment.

In D100739#2711181 <https://reviews.llvm.org/D100739#2711181>, @rjmccall wrote:

> What is the purpose of the builtin?  Where is it being used?  Typically you *can't* change the signature of a builtin because the builtin is itself a language feature that's documented to have a particular signature.  If you've made a builtin purely for use in generated AST, that's pretty unfortunate, and you should consider whether you actually have to do that instead of e.g. synthesizing a call to an allocation function the same way that we do in `new` expressions.

Well, the intention was not *only* use it in AST, it could be used by clients to ask LLVM to handle overaligned frame. I'm not sure how many use cases that could have, so in the updated patch, I've removed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100739/new/

https://reviews.llvm.org/D100739



More information about the cfe-commits mailing list