[PATCH] D101117: [clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 22 15:50:45 PDT 2021
yaxunl added a comment.
In D101117#2710368 <https://reviews.llvm.org/D101117#2710368>, @JonChesterfield wrote:
> I'm not very pleased with this. There's too much state to move around when representing the failure and the control flow is probably harder to read than it was in the original. May take another pass at it.
I am OK with this. If you would like to try more pls go ahead.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101117/new/
https://reviews.llvm.org/D101117
More information about the cfe-commits
mailing list