[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

[David Zarzycki via Phabricator via cfe-commits]

davezarzycki added a comment.

In D99949#2709673 <https://reviews.llvm.org/D99949#2709673>, @JonChesterfield wrote:

> That's interesting. The various permutations I have on disk are also all path/include/hsa/hsa.h. The existing in tree use of hsa.h is the amdgpu plugin, which uses `#include "hsa.h"` and `#include <hsa.h>`, which seems unlikely to be correct.
>
> I'm going to patch this on the fly to hsa/hsa.h as that looks very likely to be the fix.
>
> edit: or not, the include path cmake summons on my local system is `-isystem $HOME/llvm-install/include/hsa`, so hsa/hsa doesn't work.
>
> Tiresome. Will revert this for now.

Ya, I bet. I also find this interesting because this fails my "three stage" test at the third stage which is rare. My stages:

1. build and test llvm+clang (release without asserts) with the system compiler release
2. build and test llvm+clang (release with asserts) with the just build compiler
3. build and test llvm+clang (release without assert) with compiler built in stage one


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99949/new/

https://reviews.llvm.org/D99949