[PATCH] D101043: [OpenCL] Drop extension pragma handling for extension types/declarations

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 22 06:10:32 PDT 2021


Anastasia added a comment.

In D101043#2708358 <https://reviews.llvm.org/D101043#2708358>, @yaxunl wrote:

> Did you check whether this patch will cause regression in OpenCL conformance tests? If not, I am OK with it.

This change has no impact on CTS as CTS has never had negative compiler tests i.e. checking that the compiler rejects certain kernels. This change doesn't break existing kernels i.e. it only allows to compile extra kernels i.e. without the use of pragmas enable/disable when non-native compiler types or functions are called.

CTS only mainly uses `#pragma OPENCL EXTENSION * : enable` and there is only one occurrence of  `#pragma OPENCL EXTENSION * : disable` that only checks that the pragmas are accepted, there are no other relevant checks in the tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101043/new/

https://reviews.llvm.org/D101043



More information about the cfe-commits mailing list