[PATCH] D94942: [clangd] Add tweak for implementing abstract class

Christopher Rhodes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 22 01:04:52 PDT 2021


crr0004 added a comment.

One thing I noticed was that you need to be over the base class or overriding class identifier in order to get the code action.

For some editors like Visual Studio Code this is less noticeable but for others like VIM it is more noticeable as you need to know it's there.

Is there a way to trigger the tweak when it is anywhere in the class? I have been investigating how to do it but I am still learning a lot about the clang AST and the internals of clangd.

What do other people think?

Might not be worth adding to this patch as it would over-complicate an already complicated patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94942/new/

https://reviews.llvm.org/D94942



More information about the cfe-commits mailing list