[PATCH] D100819: [RISCV] Implement the vneg.v builtin.

Hsiangkai Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 21 19:57:12 PDT 2021


HsiangKai marked 3 inline comments as done.
HsiangKai added inline comments.


================
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:1048
+                       return Cmp < 0;
+                     // Some mask intrinsics use the same IRName as unmasked.
+                     // Sort the unmasked intrinsics first.
----------------
craig.topper wrote:
> frasercrmck wrote:
> > Does this only affect `vneg` or are there other changes to the tablegenned code as a consequence?
> Is this needed for fneg? When we implemented this change downstream, I thought it was for compares due to how vmsge.vx was handled.
Thanks for pointing it out. I reverted it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100819/new/

https://reviews.llvm.org/D100819



More information about the cfe-commits mailing list