[PATCH] D99233: [HIP] Add option --gpu-inline-threshold

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:954
+def gpu_inline_threshold_EQ : Joined<["--"], "gpu-inline-threshold=">,
+  Flags<[CC1Option]>,
+  HelpText<"Inline threshold for device compilation for HIP">;
----------------
tra wrote:
> This option is only handled at the top level, it does not need `CC1Option`. It does need `HelpHidden`.
> 
> Also, the option should probably be `-fgpu-inline-threshold=...` as it's a parameter tweak, and not something more serious, like `--offload-arch`.
> Naming is hard. :-)
will do


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99233/new/

https://reviews.llvm.org/D99233