[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

Wed Apr 21 11:14:13 PDT 2021

effective-light added a comment.

In D100834#2704330 <https://reviews.llvm.org/D100834#2704330>, @fhahn wrote:

> In D100834#2702550 <https://reviews.llvm.org/D100834#2702550>, @kpn wrote:
>
>> I don't know the matrix implementation so I can't swear this hits every place needed, but the uses of CGFPOptionsRAII in this patch look correct at least.
>
> Other parts of the extension include `__builtin_matrix_transpose`, indexing into a matrix and casting, but I don't think the FMFs are needed there. One thing that would be good to also test would be the compound operators, (`-=`, `+=`, `*=`). @effective-light it would be great if you could add a test for those, then LGTM from my side. If you need someone to commit the change on your behalf, please let us know and share the name + email to use for the commit authorship.

Ya, you can commit it under `Hamza Mahfooz <someguy at effective-light.com>`, thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100834/new/

https://reviews.llvm.org/D100834