[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: clang/lib/Headers/__clang_hip_cmath.h:347
+  static const bool value = !is_same<type, void>::value;
 };
 
----------------
yaxunl wrote:
> tra wrote:
> > Nit: `}; // namespace __hip`
> will do
actually this is end of struct `__numeric_type`. end of namespace `__hip` is at line 390


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100794/new/

https://reviews.llvm.org/D100794