[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 20 18:51:24 PDT 2021


thakis added a comment.

> So, if this is really causing some consternation then we can pull back and reinstate what we had, but it was a direction around solving a set of hard to find bugs.
>
> Thoughts?

This keeps the assert that checks that the llvm DataLayout and the user label prefix are in sync. See the NDEBUG in Mangle.cpp here-ish: https://reviews.llvm.org/D100776#change-NN4Lz7xH29fo (I measured that that assert doesn't slow down `check-clang` in a release+assert build too). So I don't think this regresses safety.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100776/new/

https://reviews.llvm.org/D100776



More information about the cfe-commits mailing list