[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee
Matt Arsenault via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 20 17:35:40 PDT 2021
arsenm added inline comments.
================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:130-131
"invalid argument '%0' only allowed with '%1'">;
+def err_drv_argument_only_allowed_with_or_equivalent : Error<
+ "invalid argument '%0' only allowed with '%1' or equivalent">;
def err_drv_argument_not_allowed_with : Error<
----------------
This seems like a confusing message. Equivalent of what?
================
Comment at: clang/include/clang/Driver/Options.td:3176
+ CodeGenOpts<"EmitIEEENaNCompliantInsts">, DefaultTrue,
+ PosFlag<SetTrue, [], "Setting a bit in the expected default floating point "
+ " mode register. Floating point opcodes that support exception flag "
----------------
s/Setting a bit/Sets the IEEE bit/
================
Comment at: clang/test/CodeGenOpenCL/amdgpu-ieee.cl:20
+
+// Check diagnostics when using -mno-amdgpu-ieee without NoHornorNaNs.
+
----------------
Typo Hornor
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77013/new/
https://reviews.llvm.org/D77013
More information about the cfe-commits
mailing list