[PATCH] D100907: [lsan][docs] Clarify supported platforms

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 20 16:51:48 PDT 2021


MaskRay marked an inline comment as done.
MaskRay added subscribers: fjricci, delcypher.
MaskRay added inline comments.


================
Comment at: clang/docs/LeakSanitizer.rst:49
+
+* Android aarch64/i386/x86_64
+* Linux arm/aarch64/mips64/ppc64/ppc64le/s390x/i386/x86\_64
----------------
vitalybuka wrote:
> MaskRay wrote:
> > vitalybuka wrote:
> > > Apple is incomplete and riscv is missing
> > > 
> > > ```
> > > if(APPLE)
> > >   set(ALL_LSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${MIPS64} ${ARM64})
> > > else()
> > >   set(ALL_LSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${MIPS64} ${ARM64} ${ARM32} ${PPC64} ${S390X} ${RISCV64})
> > > endif()
> > > ```
> > I'll add riscv64 for Linux.
> > 
> > But wait, lib/sanitizer_common/sanitizer_stoptheworld_mac.cpp doesn't mention mips64...
> maybe work in progress
Likely a copy-paste error from de3b9a2ecc7e9ebe3fc1780aede0223821c52d2a 

I can delete it.

CC @delcypher @fjricci  who have touched the macOS code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100907/new/

https://reviews.llvm.org/D100907



More information about the cfe-commits mailing list