[PATCH] D100755: [llvm-rc] [3/4] Run clang to preprocess input files

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo updated this revision to Diff 338969.
mstorsjo added a comment.
Herald added subscribers: cfe-commits, mgorny.
Herald added a project: clang.

- Added a testcase under clang/test/Preprocessor
- Changed the option to -no-preprocess
- Removed the env var for disabling preprocessing
- Made it look for both clang and clang-cl

This still uses --driver-mode=gcc; it currently doesn't allow setting options where --driver-mode=cl would matter, and allowing that does complicate things a little. So I'd leave that as a future improvement for when/if it becomes possible to set such options where it matters.

I'm also not adding any more convenience options like -winsysroot, -imsvc, -showincludes for now; leaving those to future patches (also possibly for people who actually use them who can verify that their use makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100755/new/

https://reviews.llvm.org/D100755

Files:
  clang/test/CMakeLists.txt
  clang/test/Preprocessor/Inputs/llvm-rc.h
  clang/test/Preprocessor/llvm-rc.rc
  clang/test/lit.cfg.py
  llvm/test/tools/llvm-rc/absolute.test
  llvm/test/tools/llvm-rc/codepage.test
  llvm/test/tools/llvm-rc/cpp-output.test
  llvm/test/tools/llvm-rc/flags.test
  llvm/test/tools/llvm-rc/helpmsg.test
  llvm/test/tools/llvm-rc/include-paths.test
  llvm/test/tools/llvm-rc/language.test
  llvm/test/tools/llvm-rc/memoryflags-stringtable.test
  llvm/test/tools/llvm-rc/memoryflags.test
  llvm/test/tools/llvm-rc/not-expr.test
  llvm/test/tools/llvm-rc/parser-expr.test
  llvm/test/tools/llvm-rc/parser.test
  llvm/test/tools/llvm-rc/preproc.test
  llvm/test/tools/llvm-rc/tag-accelerators.test
  llvm/test/tools/llvm-rc/tag-dialog.test
  llvm/test/tools/llvm-rc/tag-escape.test
  llvm/test/tools/llvm-rc/tag-html.test
  llvm/test/tools/llvm-rc/tag-icon-cursor.test
  llvm/test/tools/llvm-rc/tag-menu.test
  llvm/test/tools/llvm-rc/tag-stringtable.test
  llvm/test/tools/llvm-rc/tag-user.test
  llvm/test/tools/llvm-rc/tag-versioninfo.test
  llvm/test/tools/llvm-rc/tokenizer.test
  llvm/test/tools/llvm-rc/versioninfo-padding.test
  llvm/tools/llvm-rc/Opts.td
  llvm/tools/llvm-rc/llvm-rc.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100755.338969.patch
Type: text/x-patch
Size: 49923 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210420/27ccd51b/attachment-0001.bin>