[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

Tue Apr 20 12:33:02 PDT 2021

ab added a comment.

This sounds nice!  One idea, maybe more dangerous, not sure which is better:  in `setTripleTypeForMachOArchName`, we already have a couple `setArchName` calls, I think that's why `arm64e` is left alone in the `aarch64-cpus.c` test.  Maybe we can do the `setArchName` call for every arch there?

Another question, probably a completely separate problem: why is it still reporting darwin?  Ideally we'd want it to report macos, right?  With that + your change the triple there would be the actual triple we use to build.  (but maybe the macos bit only comes later when we pick up an SDK in DarwinClang or whatever?)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100807/new/

https://reviews.llvm.org/D100807