[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:76-86
+#if !defined(__HIPCC_RTC__)
 #include <__clang_cuda_math_forward_declares.h>
+#endif // __HIPCC_RTC__
 #include <__clang_hip_cmath.h>
+#if !defined(__HIPCC_RTC__)
 #include <__clang_cuda_complex_builtins.h>
 
----------------
tra wrote:
> I'd add an empty line separators between `#if/#endif` blocks.
> 
> Or, perhaps, it should be restructured as 
> ```
> #if defined(__HIPCC_RTC__)
> #include <__clang_hip_cmath.h>
> #else
> #include <__clang_cuda_math_forward_declares.h>
> #include <__clang_hip_cmath.h>
> #include <__clang_cuda_complex_builtins.h>
> #include <algorithm>
> #include <complex>
> #include <new>
> #endif // __HIPCC_RTC__
> ```
will restructure it


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100794/new/

https://reviews.llvm.org/D100794