[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

Mon Apr 19 13:36:35 PDT 2021

thakis added a comment.

In D100776#2699565 <https://reviews.llvm.org/D100776#2699565>, @rnk wrote:

> Of the three people who commented on D17183 <https://reviews.llvm.org/D17183>, you and I are on the only ones in favor of this approach. I think @echristo and @jyknight both preferred approach 2. I'd like to get at least an agreement to disagree from one of them before approving this.

That's 50% in people, and 15/24 voting by changes that landed in clang/ since start of year ;) Don't know why 2/2 is "only".

I'm also not dismissing approach 2: I implemented it as well, and it's ready-to-go as soon as someone wants to pursue the direction mentioned there. If someone wants to do that, I don't have a problem with it, but until then this here is simpler and more self-consistent since it preserves the original design of TargetInfo.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100776/new/

https://reviews.llvm.org/D100776