[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 19 12:12:21 PDT 2021


steakhal added a comment.

In D97183#2699080 <https://reviews.llvm.org/D97183#2699080>, @RedDocMD wrote:

> For the following function:
>
>   void foo(std::unique_ptr<A> P) {
>     A* praw = P.get();
>     A* other = praw;
>     if (other) {}
>     P->foo();
>   }
>
> Where do we expect a note? Where `praw` is initialized, where `other` is initialized or both?

I would expect no notes at all, since there is no bug.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97183/new/

https://reviews.llvm.org/D97183



More information about the cfe-commits mailing list