[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 19 09:26:32 PDT 2021


tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

Small test nit. LGTM otherwise.



================
Comment at: clang/test/CodeGenCUDA/device-use-host-var.cu:22
+
+// CHECK: store i32 1
+// CHECK: store i32 2
----------------
Nit: You may want to add a `CHECK-LABEL: <function name>`. It does not make much of a difference in this file, but is useful in general to explicitly restrict the search scope. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98193/new/

https://reviews.llvm.org/D98193



More information about the cfe-commits mailing list