[PATCH] D99936: [clang][parser] Unify rejecting (non) decl stmt with gnu attributes
Timm Bäder via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 19 02:56:18 PDT 2021
tbaeder updated this revision to Diff 338459.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99936/new/
https://reviews.llvm.org/D99936
Files:
clang/lib/Parse/ParseStmt.cpp
clang/test/SemaCXX/warn-unused-label-error.cpp
Index: clang/test/SemaCXX/warn-unused-label-error.cpp
===================================================================
--- clang/test/SemaCXX/warn-unused-label-error.cpp
+++ clang/test/SemaCXX/warn-unused-label-error.cpp
@@ -12,8 +12,8 @@
void g() {
C: // unused label 'C' will not appear here because an error has occurred
- __attribute__((unused))
- #pragma weak unused_local_static // expected-error {{expected ';' after __attribute__}}
+ __attribute__((unused)) // expected-error {{an attribute list cannot appear here}}
+ #pragma weak unused_local_static
;
}
Index: clang/lib/Parse/ParseStmt.cpp
===================================================================
--- clang/lib/Parse/ParseStmt.cpp
+++ clang/lib/Parse/ParseStmt.cpp
@@ -648,18 +648,12 @@
// attributes as part of a statement in that case). That looks like a bug.
if (!getLangOpts().CPlusPlus || Tok.is(tok::semi))
attrs.takeAllFrom(TempAttrs);
- else if (isDeclarationStatement()) {
+ else {
StmtVector Stmts;
- // FIXME: We should do this whether or not we have a declaration
- // statement, but that doesn't work correctly (because ProhibitAttributes
- // can't handle GNU attributes), so only call it in the one case where
- // GNU attributes are allowed.
SubStmt = ParseStatementOrDeclarationAfterAttributes(Stmts, StmtCtx,
nullptr, TempAttrs);
if (!TempAttrs.empty() && !SubStmt.isInvalid())
SubStmt = Actions.ActOnAttributedStmt(TempAttrs, SubStmt.get());
- } else {
- Diag(Tok, diag::err_expected_after) << "__attribute__" << tok::semi;
}
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99936.338459.patch
Type: text/x-patch
Size: 1716 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210419/dbeaa02f/attachment.bin>
More information about the cfe-commits
mailing list