[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 19 00:36:18 PDT 2021


curdeius added a comment.

In D99031#2697563 <https://reviews.llvm.org/D99031#2697563>, @aybassiouny wrote:

> After rechecking, turns out `AllowShortLambdasOnASingleLine` and `BeforeLambdaBody` both need to be turned on in order for the regression to be expressed, this affects the UT.

Please update the summary with this information.



================
Comment at: clang/unittests/Format/FormatTest.cpp:2594
+  // Make sure compact namespaces are not confused with lambdas
+  FormatStyle CompactNamespacesStyle{getLLVMStyle()};
+  CompactNamespacesStyle.CompactNamespaces = true;
----------------
Nit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99031/new/

https://reviews.llvm.org/D99031



More information about the cfe-commits mailing list