[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

Sun Apr 18 21:28:12 PDT 2021

dblaikie added a comment.

In D100630#2697728 <https://reviews.llvm.org/D100630#2697728>, @shchenz wrote:

> In D100630#2694681 <https://reviews.llvm.org/D100630#2694681>, @probinson wrote:
>
>> If DBX is going to be really pedantic about not recognizing tags or attributes that don't align with the DWARF version, maybe we're better off with really supporting `-gstrict-dwarf` and just have DBX tuning imply that.
>
> Hi @probinson thanks for pointing out the way, agree with this new solution. After checking the codes, I found there are already `-gstrict-dwarf`, `-gno-strict-dwarf` options in clang code base, but there seem no users of them. Do you happen to know the story of these two options? I get a quick search, no clue yet. Can we reuse these options for the intention here. Thanks?

I'd suggest checking the history of the commits that added them - but likely they were added for command line compatibility with gcc but I expect they're currently no-ops in Clang. Adding the expected functionality to them seems fine to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100630/new/

https://reviews.llvm.org/D100630