[PATCH] D100723: [AST] Fix comparison to of SourceRanges in container

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 18 08:37:23 PDT 2021


njames93 added inline comments.


================
Comment at: clang/lib/Tooling/NodeIntrospection.cpp:47
     std::pair<SourceRange, SharedLocationCall> const &RHS) const {
-  if (!LHS.first.isValid() || !RHS.first.isValid())
-    return false;
----------------
Maybe we should assert the ranges (or locations) are valid before inserting. Will require modification to the generator script but it would make subsequent handling simpler. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100723/new/

https://reviews.llvm.org/D100723



More information about the cfe-commits mailing list