[PATCH] D100516: [AST] Add TypeLoc support to node introspection

Stephen Kelly via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 17 15:28:15 PDT 2021


steveire added inline comments.


================
Comment at: clang/lib/Tooling/DumpTool/ASTSrcLocProcessor.cpp:172-176
+      if (TypeLocBase && Node->getName() == "getLocalSourceRange")
+        continue;
+      if ((ASTClass->getName() == "PointerLikeTypeLoc" ||
+           ASTClass->getName() == "TypeofLikeTypeLoc") &&
+          Node->getName() == "getLocalSourceRange")
----------------
njames93 wrote:
> njames93 wrote:
> > Can we have a comment explaining why we are discarding these?
> nit: can this be addressed?
There is a comment above, so I'm not sure what's missing. But please feel free to adjust it post commit!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100516/new/

https://reviews.llvm.org/D100516



More information about the cfe-commits mailing list