[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 16 00:00:31 PDT 2021


rjmccall added a comment.

I agree.  The arrangement logic is assuming that the exact pointer type doesn't matter because it's all just a pointer in the end, but of course that breaks down when we start inferring attributes.

Pointer authentication also really wants to know the original declaration which gave rise to a v-table slot, and it's not the only thing.  Maybe we should just change the v-table data structure to store that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99790/new/

https://reviews.llvm.org/D99790



More information about the cfe-commits mailing list