[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Michael Benfield via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 15 23:14:59 PDT 2021


mbenfield updated this revision to Diff 337998.
mbenfield added a comment.

Respond to comments.

- Use /// for function comment

- Improve the text of function comment

- Use SmallPtrSet instead of SmallDenseMap

- Use reference instead of pointer in AllUsesAreSetsVisitor

- Capture with [&]

- const in several places

- pragmas to ignore warnings in vector-gcc-compat.c

- in C++ test files, comment that we are following the lead of gcc in not warning for a struct


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100581/new/

https://reviews.llvm.org/D100581

Files:
  clang/include/clang/Basic/DiagnosticGroups.td
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/include/clang/Sema/Sema.h
  clang/lib/Sema/SemaDecl.cpp
  clang/lib/Sema/SemaExpr.cpp
  clang/lib/Sema/SemaStmt.cpp
  clang/test/Sema/vector-gcc-compat.c
  clang/test/Sema/warn-unused-but-set-parameters-cpp.cpp
  clang/test/Sema/warn-unused-but-set-parameters.c
  clang/test/Sema/warn-unused-but-set-variables-cpp.cpp
  clang/test/Sema/warn-unused-but-set-variables.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100581.337998.patch
Type: text/x-patch
Size: 12737 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210416/267c1d94/attachment-0001.bin>


More information about the cfe-commits mailing list