[PATCH] D100616: [clang] Fix a potential assert failure

Thu Apr 15 21:09:35 PDT 2021

craig.topper added a comment.

In D100616#2693607 <https://reviews.llvm.org/D100616#2693607>, @MaskRay wrote:

> In D100616#2693603 <https://reviews.llvm.org/D100616#2693603>, @craig.topper wrote:
>
>> In D100616#2693595 <https://reviews.llvm.org/D100616#2693595>, @MaskRay wrote:
>>
>>> SVE::FirstTSBuiltin is 8148, the largest.
>>
>> Isn't SVE::FirstTSBuiltin used to start AArch64's builtins list. So shouldn't AArch64::LastTSBuiltin be larger?
>
> You are right. I misspoke. AArch64::LastTSBuiltin is 8328.

That raises the question of why the NEON and SVE are in this list std::max at all. They're only helpers for generating the correct information for ARM and AArch64 which will always be larger.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100616/new/

https://reviews.llvm.org/D100616