[PATCH] D100617: [RISCV][Clang] Drop the assembly tests for RVV intrinsics.

Zakk Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 15 20:18:27 PDT 2021


khchen created this revision.
khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27.
Herald added subscribers: vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, asb.
khchen requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.

We had verified the correctness of all intrinsics in downstream, so
dropping the assembly tests to decrease the check-clang time.
It would remove 1/3 of the RUN lines.

https://reviews.llvm.org/D99151#2654154 mentions why we need to have
the ASM tests before.

note: I only update the one file diff to avoid to have
large changes different in review system.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100617

Files:
  clang/test/CodeGen/RISCV/rvv-intrinsics/vadd.c


Index: clang/test/CodeGen/RISCV/rvv-intrinsics/vadd.c
===================================================================
--- clang/test/CodeGen/RISCV/rvv-intrinsics/vadd.c
+++ clang/test/CodeGen/RISCV/rvv-intrinsics/vadd.c
@@ -4,10 +4,7 @@
 // RUN:   -target-feature +experimental-zfh -disable-O0-optnone -emit-llvm %s -o - | opt -S -mem2reg | FileCheck --check-prefix=CHECK-RV32 %s
 // RUN: %clang_cc1 -triple riscv64 -target-feature +f -target-feature +d -target-feature +experimental-v \
 // RUN:   -target-feature +experimental-zfh -disable-O0-optnone -emit-llvm %s -o - | opt -S -mem2reg | FileCheck --check-prefix=CHECK-RV64 %s
-// RUN: %clang_cc1 -triple riscv64 -target-feature +m -target-feature +experimental-v \
-// RUN:   -Werror -Wall -o - %s -S >/dev/null 2>&1 | FileCheck --check-prefix=ASM --allow-empty %s
 
-// ASM-NOT: warning
 #include <riscv_vector.h>
 
 // CHECK-RV32-LABEL: @test_vadd_vv_i8mf8(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100617.337975.patch
Type: text/x-patch
Size: 919 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210416/77d6373a/attachment-0001.bin>


More information about the cfe-commits mailing list