[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

Thu Apr 15 15:49:54 PDT 2021

dblaikie added inline comments.

================
Comment at: clang/lib/CodeGen/CGExpr.cpp:2840
+    // Emit debuginfo for the function declaration if the target wants to.
+    if (getContext().getTargetInfo().allowDebugInfoForExternalVar()) {
+      CGDebugInfo *DI = CGM.getModuleDebugInfo();
----------------
yonghong-song wrote:
> dblaikie wrote:
> > Seems like this should be renamed given it's being used for things other than external variables?
> I noticed this but didn't change it as I thought the current name is *sort of* okay. But you are right. It is not precise. Will change to "allowDebugInfoForExternalRef()" and resubmit. Let me know if you have better function name suggestion.
Sounds good to me, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100567/new/

https://reviews.llvm.org/D100567