[PATCH] D100590: DeclContext: Fix iterator category

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 15 11:54:04 PDT 2021


HazardyKnusperkeks created this revision.
HazardyKnusperkeks added reviewers: rsmith, v.g.vassilev.
HazardyKnusperkeks added projects: clang, clang-tools-extra, LLDB.
Herald added a subscriber: JDevlieghere.
HazardyKnusperkeks requested review of this revision.
Herald added a subscriber: cfe-commits.

This amends 0cb7e7ca0c864e052bf49978f3bcd667c9e16930 <https://reviews.llvm.org/rG0cb7e7ca0c864e052bf49978f3bcd667c9e16930>. (D91524 <https://reviews.llvm.org/D91524>)

The iterator category of lookup_iterator was changed, but here it stayed
hardcoded as random access. Found while trying to build Clazy.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100590

Files:
  clang/include/clang/AST/DeclBase.h


Index: clang/include/clang/AST/DeclBase.h
===================================================================
--- clang/include/clang/AST/DeclBase.h
+++ clang/include/clang/AST/DeclBase.h
@@ -2378,7 +2378,7 @@
 
   using udir_iterator_base =
       llvm::iterator_adaptor_base<udir_iterator, lookup_iterator,
-                                  std::random_access_iterator_tag,
+                                  typename lookup_iterator::iterator_category,
                                   UsingDirectiveDecl *>;
 
   struct udir_iterator : udir_iterator_base {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100590.337858.patch
Type: text/x-patch
Size: 564 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210415/10346837/attachment.bin>


More information about the cfe-commits mailing list