[PATCH] D100467: [clang] [AArch64] Fix handling of HFAs passed to Windows variadic functions

[Reid Kleckner via Phabricator via cfe-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, micro readability suggestion



================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:5691
+  // no special handling of HFAs/HVAs.
+  if (isHomogeneousAggregate(Ty, Base, Members) && (!IsWin64 || !IsVariadic)) {
     return ABIArgInfo::getDirect(
----------------
nit: I feel like this would be more readable and short-circuit better:
  bool IsWinVariadic = IsWin64 && IsVariadic;
  if (!IsWinVariadic && isHomogeneousAggregate(...)) {


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100467/new/

https://reviews.llvm.org/D100467