[PATCH] D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types
Sven van Haastregt via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 15 04:00:45 PDT 2021
svenvh added inline comments.
================
Comment at: clang/lib/Sema/SemaDecl.cpp:8673
+ // reference if an implementation supports them in kernel parameters.
+ if (!PointeeType->isAtomicType() && !PointeeType->isVoidType() &&
+ !PointeeType->isStandardLayoutType())
----------------
I am wondering if this should be made conditional on C++ mode? Or is there no possible way that this new `return InvalidKernelParam` can be triggered from OpenCL C mode?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100471/new/
https://reviews.llvm.org/D100471
More information about the cfe-commits
mailing list