[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 15 02:47:27 PDT 2021


lebedev.ri abandoned this revision.
lebedev.ri added a comment.

You know, somehow i don't think me wasting 30 more hours on this to experimentally find a working permutation is productive.



================
Comment at: clang/include/clang/Basic/Thunk.h:157
+
+  /// Holds a pointer to the overridee(!) method this thunk is for,
+  /// if needed by the ABI to distinguish different thunks with equal
----------------
rsmith wrote:
> Isn't this the same as `BaseMethod.getDecl()`? (I'd expect "overridee" and "overridden" to be synonymous, contrasting with the "overrider" which would be the derived-class function.)
Oh, hmm. That makes more sense indeed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100388/new/

https://reviews.llvm.org/D100388



More information about the cfe-commits mailing list