[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

Chirag Khandelwal via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 15 01:04:20 PDT 2021


AMDChirag updated this revision to Diff 337654.
AMDChirag added a comment.
Herald added a subscriber: jfb.

Fixed cancel construct and applied updates to its test cases

The test cases are updated so that the IR generated with and without IRBuilder are considered as they are different.

The cancel codegenerator with IRBuilder causes the IR to be created in the form:

  ...
  %29 = call i32 @__kmpc_cancel(%struct.ident_t* @1, i32 %omp_global_thread_num9, i32 3)
  %30 = icmp eq i32 %29, 0
  ...

Whereas, without IRBuilder, the IR created is in the form:

  ...
  %20 = call i32 @__kmpc_cancel(%struct.ident_t* @1, i32 %0, i32 3)
  %21 = icmp ne i32 %20, 0
  ...

In essence, the output is logically same, but semantically different, hence the requirement of updating test cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91054/new/

https://reviews.llvm.org/D91054

Files:
  clang/lib/CodeGen/CGOpenMPRuntime.cpp
  clang/lib/CodeGen/CGStmtOpenMP.cpp
  clang/test/OpenMP/cancel_codegen.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91054.337654.patch
Type: text/x-patch
Size: 107017 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210415/298c40b4/attachment-0001.bin>


More information about the cfe-commits mailing list