[PATCH] D100425: [WebAssembly] Codegen for f64x2.convert_low_i32x4_{s,u}

[Thomas Lively via Phabricator via cfe-commits]

tlively added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1104-1107
+defm "" : SIMDConvert<F32x4, I32x4, sint_to_fp, "convert_i32x4_s", 250>;
+defm "" : SIMDConvert<F32x4, I32x4, uint_to_fp, "convert_i32x4_u", 251>;
+defm "" : SIMDConvert<F64x2, I32x4, convert_low_s, "convert_low_i32x4_s", 0xfe>;
+defm "" : SIMDConvert<F64x2, I32x4, convert_low_u, "convert_low_i32x4_u", 0xff>;
----------------
aheejin wrote:
> Not related to this CL, but we write encoding as decimals for some instructions and hexadecimals in others?
I prefer hexadecimal because that's what all the SIMD documentation uses so it's easier to check for correctness, but for some reason I used to use decimal. I think I didn't realize hexadecimal was an option in .td files for a while. I would like to converge on using hexadecimal uniformly eventually.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100425/new/

https://reviews.llvm.org/D100425