[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

[Louis Dionne via Phabricator via cfe-commits]

ldionne added a comment.

Well, one way to see things is that this patch only makes yet another step in a direction that we're already rather far in (in terms of CMake complexity). And as I said, I think the separation of `__config_site` in its own platform-specific directory makes a lot of sense. So don't consider yourself blocked on libc++.

I do have some questions regarding the driver side of things though. What platforms is this change going to impact on the Driver side? Fuchsia is self-explanatory, but what does the Gnu driver impact? Also, have you thought about using this scheme instead? Why did you opt for the scheme you selected?

  include/
    c++/
      v1/
        <libc++ headers except for __config_site>
        <target1>/
            __config_site
        <target2>/
            __config_site


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89013/new/

https://reviews.llvm.org/D89013