[PATCH] D100450: [libTooling] Add smart pointer support to the `access` Stencil

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 14 05:39:43 PDT 2021


ymandel accepted this revision.
ymandel added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: clang/unittests/Tooling/StencilTest.cpp:410
+  StringRef Id = "id";
+  testExpr(Id, Snippet, access(Id, "field"), "(*x).field");
+}
----------------
Hmm. Looks like we could use smart pointer support in tooling::buildAddressOf as well.  If you're interested, the code is at
clang/lib/Tooling/Transformer/SourceCodeBuilders.cpp line 94
but I understand if you want to stop here. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100450/new/

https://reviews.llvm.org/D100450



More information about the cfe-commits mailing list