[PATCH] D100378: [AST] Use IntrusiveRefCntPtr for Introspection LocationCall.

[David Blaikie via Phabricator via cfe-commits]

dblaikie added inline comments.


================
Comment at: clang/lib/Tooling/NodeIntrospection.cpp:60
+  if (LHS.first == RHS.first)
+    return LHS.second->name() < RHS.second->name();
+  return LHS.first < RHS.first;
----------------
njames93 wrote:
> This is a slight change in behaviour, The old implementation used the operator< on a `std::shared_ptr`.
> That in turns boils down to a comparison on the raw pointer, which is less than ideal.
Why is that less than ideal? Does the ordering need to be stable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100378/new/

https://reviews.llvm.org/D100378