[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 13 23:27:50 PDT 2021


hokein added a comment.

a small suggestion to simplify the tests.



================
Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-equivalentbitwidth-off.cpp:1
+// RUN: %check_clang_tidy %s cppcoreguidelines-narrowing-conversions %t \
+// RUN: -config="{CheckOptions: [ \
----------------
instead of having multiple individual test files, I think we can group them into a single file, you can use the flag `-check-suffix=`, like

```
// RUN: %check_clang_tidy -check-suffix=TESTCASE1 ...
// RUN: %check_clang_tidy -check-suffix=TESTCASE2 ...


// some warning code for test-case1
CHECK-MESSAGES-TESTCASE1: ....
``` 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99543/new/

https://reviews.llvm.org/D99543



More information about the cfe-commits mailing list