[PATCH] D100282: [Coroutines] Set presplit attribute in Clang instead of CoroEarly pass

Tue Apr 13 20:16:01 PDT 2021

lxfind added a comment.

In D100282#2687532 <https://reviews.llvm.org/D100282#2687532>, @ychen wrote:

> I think the setting is in CoroEarly from the beginning is that it is an implementation detail? Clients should only worry about coroutine shape.  Maybe we could set `noinline` in frontends to express the intent and remove it in coroearly/corosplit?

We cannot do that, because we need to distinguish between user-specified noinline vs coroutine. Some coroutines in theory could potentially be inlined.
Our choice is really just between setting it in the front-end or moving CoroEarly to the beginning of the pipeline.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100282/new/

https://reviews.llvm.org/D100282