[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 13 14:46:09 PDT 2021


MaskRay added a comment.

This touches sanitizers so hope #sanitizers <https://reviews.llvm.org/tag/sanitizers/> folks can weigh in as well.



================
Comment at: llvm/include/llvm/IR/Function.h:156
 
+  static Function *createWithDefaultAttr(FunctionType *Ty, LinkageTypes Linkage,
+                                         unsigned AddrSpace,
----------------
nickdesaulniers wrote:
> Perhaps a comment that this "creates functions with module level attributes applied at the function level. Use this when synthesizing new functions that might have attributes that depend on module level attributes that would have been set by command line flags" or such.
Thanks. This definitely deserves a comment. I will add when I update it:)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100251/new/

https://reviews.llvm.org/D100251



More information about the cfe-commits mailing list