[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 13 11:18:53 PDT 2021


aaron.ballman closed this revision.
aaron.ballman added a comment.

In D100346#2686407 <https://reviews.llvm.org/D100346#2686407>, @ThePhD wrote:

> In D100346#2686342 <https://reviews.llvm.org/D100346#2686342>, @aaron.ballman wrote:
>
>> Okay, I'm sold. Thank you for the detailed explanation! The changes LGTM. Do you have commit privileges or would you like me to commit on your behalf? (If you'd like me to commit, what email address and name would you like me to use for commit attribution?)
>
> I don't have commit privileges! You should use `ThePhD <phdofthehouse at gmail.com>`.

Thank you for the contribution! I've commit it on your behalf in 701d70d4c25c4e02b303ba6dee1495708496f615 <https://reviews.llvm.org/rG701d70d4c25c4e02b303ba6dee1495708496f615>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100346/new/

https://reviews.llvm.org/D100346



More information about the cfe-commits mailing list