[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 12 09:13:51 PDT 2021


alexfh accepted this revision.
alexfh added a comment.

LG with a couple of nits.



================
Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:230
+  explicit FunctionASTVisitor(const bool IgnoreMacros)
+      : IgnoreMacros(IgnoreMacros){};
+
----------------
nit: Please remove the semicolon and clang-format.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-function-cognitive-complexity.rst:31
+   any macro arguments are ignored, even if they should count to the complexity.
+   As this might change in the future, this option isn't guarantueed to be
+   forward-compatible. Default is `false`.
----------------
typo: "guarantueed" -> "guaranteed".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98070/new/

https://reviews.llvm.org/D98070



More information about the cfe-commits mailing list