[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

Paul Robinson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 12 07:52:59 PDT 2021


probinson added a comment.

I am not 100% convinced this has the desired effect.  I believe what it does is:

- Search for the first occurrence of each of "val" "moParam" and "mcParam"
- After the last of the above occurrences, ensure there are no other occurrences of "val" "moParam" or "mcParam"

That is, it wouldn't fail on input of

  "val"
  "val"
  "moParam"
  "mcParam"

...because the second appearance of "val" is before the last text matched by one of the DAG directives.

I think really what you want is to specify the three variable names using {{--implicit-check-not}} on the FileCheck command, which (I am pretty sure) will apply to everything not explicitly matched by a CHECK directive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100298/new/

https://reviews.llvm.org/D100298



More information about the cfe-commits mailing list