[PATCH] D100276: [clang] p1099 using enum part 1

Mon Apr 12 06:00:46 PDT 2021

urnathan added inline comments.

================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:12144
       NameInfo.getName().getNameKind() != DeclarationName::CXXConstructorName) {
+    // FIXME: 2021-04-07: When was this hack needed?  Can it be deleted now?
     // HACK: Work around a bug in libstdc++'s detection of ::gets. Sometimes
----------------
urnathan wrote:
> I noticed this in passing.  I have found it useful to add dates in such workaround comments -- having found really old ones in GCC that have been obsolete for like 15 years or more :)  Which  version(s) of libstdc++ got this wrong?
to answer my own question:
f501cc313e9e0 (Richard Smith         2012-10-05 01:46:25 +0000

Workaround for libstdc++4.6 <atomic> bug: make comment more explicit about what's going on, per Sean Silva's suggestion.

the last 4.6 release was GCC 4.6.4 in 2013-04-12

so (a) probably removable but I've not checked if/when libstdc++ fixed the problem, and (b) should be treated as a separate issue, of course.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100276/new/

https://reviews.llvm.org/D100276