[PATCH] D99231: [AST] Add introspection support for more base nodes

Stephen Kelly via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 12 04:33:59 PDT 2021


steveire added inline comments.


================
Comment at: clang/include/clang/AST/DeclCXX.h:2270
   SourceLocation getEllipsisLoc() const {
-    assert(isPackExpansion() && "Initializer is not a pack expansion");
+    if (!isPackExpansion())
+      return {};
----------------
njames93 wrote:
> I'm not sure about this change, but I'm guessing there's not a nice way to predicate these kinds of things
Yep.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99231/new/

https://reviews.llvm.org/D99231



More information about the cfe-commits mailing list