[clang-tools-extra] 2dd22da - [libtooling][clang-tidy] Fix compiler warnings in testcase [NFC]

[Mikael Holmen via cfe-commits]

Author: Mikael Holmen
Date: 2021-04-12T08:26:46+02:00
New Revision: 2dd22da965ffc1623421cb8163947d7e679ce187

URL: https://github.com/llvm/llvm-project/commit/2dd22da965ffc1623421cb8163947d7e679ce187
DIFF: https://github.com/llvm/llvm-project/commit/2dd22da965ffc1623421cb8163947d7e679ce187.diff

LOG: [libtooling][clang-tidy] Fix compiler warnings in testcase [NFC]

Without the fix we get:

06:31:09 In file included from ../../clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp:3:
06:31:09 ../utils/unittest/googletest/include/gtest/gtest.h:1392:11: error: comparison of integers of different signs: 'const int' and 'const unsigned int' [-Werror,-Wsign-compare]
06:31:09   if (lhs == rhs) {
06:31:09       ~~~ ^  ~~~
06:31:09 ../utils/unittest/googletest/include/gtest/gtest.h:1421:12: note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<int, unsigned int>' requested here
06:31:09     return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
06:31:09            ^
06:31:09 ../../clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp:60:3: note: in instantiation of function template specialization 'testing::internal::EqHelper<false>::Compare<int, unsigned int>' requested here
06:31:09   EXPECT_EQ(4, Errors[0].Message.FileOffset);
06:31:09   ^
06:31:09 ../utils/unittest/googletest/include/gtest/gtest.h:1924:63: note: expanded from macro 'EXPECT_EQ'
06:31:09                       EqHelper<GTEST_IS_NULL_LITERAL_(val1)>::Compare, \
06:31:09                                                               ^
06:31:09 ../utils/unittest/googletest/include/gtest/gtest.h:1392:11: error: comparison of integers of different signs: 'const int' and 'const unsigned long' [-Werror,-Wsign-compare]
06:31:09   if (lhs == rhs) {
06:31:09       ~~~ ^  ~~~
06:31:09 ../utils/unittest/googletest/include/gtest/gtest.h:1421:12: note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<int, unsigned long>' requested here
06:31:09     return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
06:31:09            ^
06:31:09 ../../clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp:64:3: note: in instantiation of function template specialization 'testing::internal::EqHelper<false>::Compare<int, unsigned long>' requested here
06:31:09   EXPECT_EQ(1, Errors[0].Message.Ranges.size());
06:31:09   ^
06:31:09 ../utils/unittest/googletest/include/gtest/gtest.h:1924:63: note: expanded from macro 'EXPECT_EQ'
06:31:09                       EqHelper<GTEST_IS_NULL_LITERAL_(val1)>::Compare, \
06:31:09                                                               ^
06:31:09 2 errors generated.

Added: 
    

Modified: 
    clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp b/clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp
index 9760e3ff5af4f..f1c5bd29e9453 100644
--- a/clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp
+++ b/clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp
@@ -57,13 +57,13 @@ TEST(ClangTidyDiagnosticConsumer, HandlesSourceRangeHighlight) {
   // int abc;
   // ____^
   // 01234
-  EXPECT_EQ(4, Errors[0].Message.FileOffset);
+  EXPECT_EQ(4ul, Errors[0].Message.FileOffset);
 
   // int abc
   // ~~~~~~~   -> Length 7. (0-length highlights are nonsensical.)
-  EXPECT_EQ(1, Errors[0].Message.Ranges.size());
-  EXPECT_EQ(0, Errors[0].Message.Ranges[0].FileOffset);
-  EXPECT_EQ(7, Errors[0].Message.Ranges[0].Length);
+  EXPECT_EQ(1ul, Errors[0].Message.Ranges.size());
+  EXPECT_EQ(0ul, Errors[0].Message.Ranges[0].FileOffset);
+  EXPECT_EQ(7ul, Errors[0].Message.Ranges[0].Length);
 }
 
 } // namespace test