[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 9 07:14:59 PDT 2021


balazske added a subscriber: Eugene.Zelenko.
balazske added a comment.

In D97960#2611531 <https://reviews.llvm.org/D97960#2611531>, @Eugene.Zelenko wrote:

> I think call stack may be useful for other checks too. May be code should be moved to utilities?

Yes it is useful for other checks, but the code here is specialized for this problem only. It is possible to make a call graph that stores the "parents" of the calls, probably root items that are of a special kind, and can add notes for call chain. But there is already a `clang::CallGraph` that can compute call graph, if I remember correctly it was not usable here because the parent node (caller) is not available. That `CallGraph` could be extended too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97960/new/

https://reviews.llvm.org/D97960



More information about the cfe-commits mailing list