[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

[Anton Zabaznov via Phabricator via cfe-commits]

azabaznov added inline comments.


================
Comment at: clang/lib/Basic/TargetInfo.cpp:398
+    auto CLVer = Opts.OpenCLCPlusPlus ? 200 : Opts.OpenCLVersion;
+    if (CLVer >= 300) {
+      auto &OCLOpts = getSupportedOpenCLOpts();
----------------
Anastasia wrote:
> azabaznov wrote:
> > Anastasia wrote:
> > > I suggest we move this onto `OpenCLOptions::addSupport`.
> > This should stay here to control simultaneous macro definitions
> Could we leave this bit out? These are set correctly by the targets already... and I think targets do need to set those explicitly indeed. I don't see big value in this functionality right now.
There are 2 reasons why it should be here

1) Simultaneous macro definition

2) Correct option processing: we need to remove `cl_khr_fp64` macro if `-cl-ext=-__opencl_c_fp64` specified


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96524/new/

https://reviews.llvm.org/D96524